Fix a few small bugs in CFLocale #946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds missing mutex unlock in an error path
* Fixes use of an incorrect local variable
* Addresses a few areas where _prefs member was assumed to be non-NULL
* Fix to __CFLocaleGetMeasurementSystemGuts and __CFLocaleCopyTemperatureUnit
modelled after __CFLocaleCopyCollatorID
* Fix to __CFLocaleEqual handles the case where one or both CFLocales
have NULL _prefs.
|
@parkera Please let me know if I should stop mentioning you on these CF patches, but it seems like you're the right person for these. |
|
@swift-ci please test |
|
@mark1smi That's fine, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modelled after __CFLocaleCopyCollatorID
have NULL _prefs.